-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test/rule-matches): var -> const & let #4497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have an accidental revert in here.
assert.isTrue(rule.matches(node, virtualNode)); | ||
} | ||
); | ||
}); | ||
}); | ||
|
||
describe('aside should not match when scoped to a sectioning content element unless it has an accessible name', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have accidentally reverted https://github.com/dequelabs/axe-core/pull/4469/files#diff-0ef6a2f04e39c405fcbf972fe657cad972110dc05e1a7d757d5a171e4a69140a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, just tried to fix this by checking out the version from develop
and making the updates again manually
For
test/rule-matches
Smaller part of the full vision: #4444